Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some CSS to make the footer sticky to the bottom [ref #2747] #5560

Merged
merged 3 commits into from
Feb 20, 2019

Conversation

mheppler
Copy link
Contributor

Related Issues

Pull Request Checklist

min-height:100%;
}
body {
/* /* Sticky footer Margin bottom by footer height */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to have 2 open comment /*s?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 17.341% when pulling 8dfa2cf on 2747-sticky-footer into 3721306 on develop.

@kcondon kcondon merged commit eb3c5c4 into develop Feb 20, 2019
@kcondon kcondon deleted the 2747-sticky-footer branch February 20, 2019 18:12
@pdurbin pdurbin added this to the 4.12 milestone Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants